On 17 Dec 2009, at 15:46, Greg Ercolano wrote: >> >> To be sure: Greg, would you please check what the definition of >> POLL* in winsock2.h is? > > Here's what's defined in the winsock2.h file: > > ---- snip > > So if I read that right, the net effect is: > > #define POLLIN 0x0300 > #define POLLOUT 0x0010 > #define POLLERR 0x0001 > > ..and what we have in FLTK is: > > # define POLLIN 1 > # define POLLOUT 4 > # define POLLERR 8 > > ..which is quite different. > > I guess that's why they call it winsock "2" ?
I don't *think* it matters what value we use, so long as we are consistent internally - at least so far as our code is concerned... But I think we are hoping that there's one bit per choice, so we can or 'em together. Now MS seem to have used a set of their own values where POLLIN is already the union of two bits indicating (I assume) in-band and out- of-band data on the pipe. Which maybe makes no real difference, at the end of the day... I guess an alternate option is for Fl_Win32.cxx to undef the "bad" values set by MS and just use our regular values internally? So long as our "local" values are only visible within Fl_Win32.cxx I think that should be alright...? Can we (and by "we" here I guess I mean Greg again...) try that and see if it actually works OK? Or I could be talking rubbish again. > >>>> c:\fltk-1.3.x-r6960\src\Fl_win32.cxx(1477) : error C2248: >>>> 'FORCE_POSITION' : cannot access protected enumerator declared >>>> in class 'Fl_Widget' >>>> ../..\FL/Fl_Widget.H(151) : see declaration of >>>> 'FORCE_POSITION' >>>> ../..\FL/Fl_Widget.H(91) : see declaration of 'Fl_Widget' > >> Somewhere in the Fl_Widget.H there is: >> friend class Fl_Group; > > I think that error line in Fl_win32.cxx is part of Fl_X::make()'s > definition, > so not sure how the "friend class Fl_Group" would help..? Meh, OK. I had thought we were doing Fl_Window stuff, which derives from Fl_Group of course, so the friend would make a difference. But apparently not. I wonder why other complers are not complaining though? In any case, making it public is probably OK? -- Ian _______________________________________________ fltk-dev mailing list [email protected] http://lists.easysw.com/mailman/listinfo/fltk-dev
