me:
>>     src/xutf8/fl_wcwidth.c
>>         #include "mk_wcwidth.c"
>>         int fl_wcwidth(unsigned int ucs) {
>>             return mk_wcwidth(ucs);
>>         }

Ian:
> I liked my version better...

Mine is just the minimum needed to get started. Pre-condition checks
and #ifdef code can be added later.

>> but then it struck me that there are no existing fl_* files in xutf8.
>> If there's a logic to how the files are partitioned, I can't see it.

> I think the xutf8 stuff was originally sort of X11 specific (though
> may not be now...) and the fltk stuff was in fl_utf.c, or some such.
> Then there was fl_utf8.cxx as well... I'm not sure which of those two
> is best though: one is derived from OksiD's stuff, the other from the
> fltk2 port. There is some overlap of functionality...

fl_wcwidth.c is C rather than C++ so I did wonder about that too, but
put the doxygen comment and function prototype in fl_utf8.cxx because
that's where the others were.

>> [*] Some thoughts on tweaks:
>> [...]

> Yes. and we can probably lose the "compatibility" *_cjk functions
> from wcwidth.c too, as they are not useful to us here.

If they are "static" they won't leak, but we can also #ifdef them out.

D.

_______________________________________________
fltk-dev mailing list
[email protected]
http://lists.easysw.com/mailman/listinfo/fltk-dev

Reply via email to