[email protected] wrote:
> Author: matt
> Date: 2010-04-13 05:28:46 -0700 (Tue, 13 Apr 2010)
> New Revision: 7489
> Log:
> Fluid: IDE. Removed some redundant code.
Very useful, but let me add a few notes...
> Modified:
> branches/branch-1.3/fluid/ide_maketools.cxx
>
> Modified: branches/branch-1.3/fluid/ide_maketools.cxx
> ===================================================================
> --- branches/branch-1.3/fluid/ide_maketools.cxx 2010-04-12 15:21:35 UTC
> (rev 7488)
> +++ branches/branch-1.3/fluid/ide_maketools.cxx 2010-04-13 12:28:46 UTC
> (rev 7489)
> @@ -89,15 +89,14 @@
> ~Maketools_IDE() {
> if (rootDir) free(rootDir);
> }
> -
> - int writeMainMakefile(const char *filepath) {
> - FILE *f = fopen(filepath, "wb");
> +
> + int fput_copyright(const char *str, FILE *f) {
> fputs("#\n", f);
> - fputs("# \"$Id: Makefile 6798 2009-06-27 16:39:36Z fabien $\"\n", f);
> + fputs("# \"$Id: $\"\n", f);
This should read:
+ fputs("# \"$Id$\"\n", f);
i.e. the Id string should be "$Id$" only. I don't think that it would
matter, though, but anyway. IIRC, subversion will remove the extraneous
text when the file is committed.
http://svn.easysw.com/public/fltk/fltk/branches/branch-1.3/fluid/Makefile
http://www.fltk.org/cmp.php
> - fputs("# Copyright 1998-2009 by Bill Spitzak and others.\n", f);
> + fputs("# Copyright 1998-2010 by Bill Spitzak and others.\n", f);
As Mike mentioned elsewhere, the first year should be the year of file
creation. Thus we should retain the year, maybe as an argument to
fput_copyright()? But maybe this is moot, because all are from 1998?
The second year could probably be the current year. If true, his could
be "calculated" from current date (no more changes in the future).
Otherwise, if it should be the year of last modification, then we would
need another parameter for the function.
> + int fput_footer(FILE *f) {
> + fputs("\n", f);
> + fputs("#\n", f);
> + fputs("# End of \"$Id: $\".\n", f);
As above, this should read:
+ fputs("# End of \"$Id$\".\n", f);
Just my 2 ct - hope you don't mind.
Albrecht
_______________________________________________
fltk-dev mailing list
[email protected]
http://lists.easysw.com/mailman/listinfo/fltk-dev
