On 23.12.2010 17:24, Manolo Gouy wrote:

> I had to stop declaring fl_xid inline under OS X because the class
> Fl_X is not part of the public API, whereas fl_xid() is.
> This explains why I added fl_xid() to Fl_cocoa.mm.

okay, I see

> The Fl::first_window() function is the single instance in all of
> FLTK that calls fl_xid().

Oops, I found 53 hits in 17 different files in src/*.c*

$ grep fl_xid src/*.c* | wc -l
53
$ grep fl_xid src/*.c* | cut -f1 -d':' | sort -u | wc -l
17

> Not to loose in efficiency with
> the loss of inlining, I have replaced it by its equivalent.
> This explains the change in Fl.cxx.

Okay, but the original looks cleaner ;-)

> In sum, these changes are quite volontary. I have checked that
> make builds under Linux and MSWindows, and make+CMake+Xcode builds
> under Mac OS X all run smoothly.

Tested Linux and Windows 'make' builds as well, so I'm okay with it,
but let's leave the others as is ;-)

Albrecht
_______________________________________________
fltk-dev mailing list
[email protected]
http://lists.easysw.com/mailman/listinfo/fltk-dev

Reply via email to