On 30.05.2011 17:19, Matthias Melcher wrote: > > On 30.05.2011, at 17:10, Albrecht Schlosser wrote:
... >> But... why should all this thread stuff be in the fltk3 namespace >> at all? I *removed* all that fltk3 namespace stuff from threads.h, >> and here is my patch (some lines may wrap): > > Well, noe you functions are in the global namespace and may collide with > other names elsewhere in your program. The namespace idea is to securely > separate external library code from the main code. Yes, I must admit my shot was too quick ;-) But I still think that "fltk3" might not the *optimal* namespace for the test code. I wouldn't like to add "private" code to FLTK's namespace (fltk3) in the real world - this could lead to confusion. And since someone might be inclined to copy the test code, we should probably not have fltk3 as namespace in the *test* code. IMHO this should be reserved to the library code itself. A user would maybe look for fltk3::Thread in the FLTK docs and wouldn't find it. That was my primary idea. Removing it may have been bad as well, though. (And, yes, I've seen (later) that the 1.x code used fl_ as prefix for the same reason ;-) ) Albrecht _______________________________________________ fltk-dev mailing list [email protected] http://lists.easysw.com/mailman/listinfo/fltk-dev
