> > I like the spaces, though... A little whitespace[1] breaks > up the line > > nicely and aids readability I always think. > > Me too. You noticed the smiley, didn't you? Maybe I should > have written <sarcasm on>...<sarcasm off>.
Yes - I just wanted to stick in the ref to "whitespaces"! > I really don't know how we should proceed > with these warnings. If you find only one bug, then they might have > done a good job, but otherwise you'll get more and more parentheses, > and I read a comment somewhere that this would make the code > unreadable. > Maybe that's correct to some degree. I do find the braces cluttering the code. But, I like a "quiet" build, too. Maybe if we add braces any time we are working on a section of code anyway, then over time these warnings will reduce (without making a concerted effort to address them...) Not sure. > Other warnings may be more useful, though: > > Fl_Preferences.cxx:684: warning: suggest explicit braces to avoid > ambiguous 'else' These we maybe should sort? Just in case... > Fl_Text_Buffer.cxx:1346: warning: array subscript has type 'char' Never really understood why this was "bad" - if the array is smaller than 127 elements, then a char is big enough? > Fl_x.cxx:354: warning: deprecated conversion from string > constant to 'char*' > Fl_x.cxx:468: warning: deprecated conversion from string > constant to 'char*' Yup - lots of these. I suppose the danger is that the string constant will be written to, when it is not in writeable memory, causing a segfault... > > These were with gcc 4.x on Windows, but on Linux there are some more > like: > > Fl_File_Chooser2.cxx: In member function 'void > Fl_File_Chooser::fileNameCB()': > Fl_File_Chooser2.cxx:864: warning: format not a string literal and no > format arguments Yup - not even sure what that really means... > > We should discuss this probably in fltk.development. Yes... SELEX Galileo Ltd Registered Office: Sigma House, Christopher Martin Road, Basildon, Essex SS14 3EL A company registered in England & Wales. Company no. 02426132 ******************************************************************** This email and any attachments are confidential to the intended recipient and may also be privileged. If you are not the intended recipient please delete it from your system and notify the sender. You should not copy it or use it for any purpose nor disclose or distribute its contents to any other person. ******************************************************************** _______________________________________________ fltk mailing list [email protected] http://lists.easysw.com/mailman/listinfo/fltk
