On 05.02.2011, at 21:21, Greg Ercolano wrote: > Matthias Melcher wrote: >>> Hmm, you should only be including Fl_Native_File_Chooser.H, >>> not Fl_Native_File_Chooser_FLTK.H. >> >> Which reminds me: can't we move the content of all the >> Fl_Native_File_Chooser_XXX.H >> files into the Fl_Native_File_Chooser.H file? > > I investigated doing that while developing the code, but due to the > platform-specific nature of the native file choosers, it involved having > #ifdef's peppered throughout the class which I thought made it > ugly and unreadable.
Sorry, I felt like I had to do it anyways. The changes were actually pretty small because I was able to reuse a lot of code (all of the public interface), and remove all the #ifdef DOXYGEN lines). With this solution, we avoid any differences in the public interface. Please check the changes, as I can currently check only OS X. >> This issue will keep repeating itself otherwise. > > It shouldn't repeat with the correction to the docs. > The docs were pointing to the wrong file (see my followups). > I was wondering why folks kept including the wrong file..! > > I don't think folks are perusing the include dir looking for files > to include, they were just getting wrong info from the docs. No, but some smart IDE's do. I use code completion all the time, and when I type include statements (or any other statement, all I type is Fl_Nat<esc>, and I will get a choice of all 4 includes in the pulldown menu. Since this is on a Mac, I could be inclined to choose Fl_Native_File_Chooser_MC.H from the pulldown menu. Please revert the SVN if you don't like the change (I love SVN ;-) - Matthias _______________________________________________ fltk mailing list [email protected] http://lists.easysw.com/mailman/listinfo/fltk
