The fix is now in the official trunk. Thanks Chris. On Sun, Dec 6, 2009 at 2:22 PM, Chris C <[email protected]> wrote:
> Ok, I've committed a fix for this and sent a pull request. > > On Dec 6, 2:45 am, Chris C <[email protected]> wrote: > > I'm just pointing out potential breaking changes, should really > > maintain a log of these so when publishing new releases they can be > > listed. > > > > On Dec 6, 12:30 am, James Gregory <[email protected]> wrote: > > > > > > > > > I wouldn't be concerned about people relying on this behaviour, it's > > > quite obviously a bug and it should be fixed. Well spotted. > > > > > On 12/6/09, Chris C <[email protected]> wrote: > > > > > > This seems like a bug to me, ClassInstance only resets the value of > > > > nextBool if the mapping is specified: > > > > > > E.g. > > > > if (!mapping.IsSpecified("DynamicInsert")) > > > > { > > > > mapping.DynamicInsert = nextBool; > > > > nextBool = true; > > > > } > > > > > > So if we assume DynamicInsert is specified, and DynamicUpdate is NOT > > > > specified the following would fail: > > > > > > instance.Not.DynamicInsert(); //nextBool left as false as > > > > DynamicInsert was specified. > > > > instance.DynamicUpdate(); //should be true, but will mistakenly be > set > > > > to false. > > > > > > Fixing this bug however will be a breaking change, as some clients > may > > > > unknowingly be relying upon this behavior. > > > > > > -- > > > > > > You received this message because you are subscribed to the Google > Groups > > > > "Fluent NHibernate" group. > > > > To post to this group, send email to > [email protected]. > > > > To unsubscribe from this group, send email to > > > > [email protected]<fluent-nhibernate%[email protected]> > . > > > > For more options, visit this group at > > > >http://groups.google.com/group/fluent-nhibernate?hl=en. > > -- > > You received this message because you are subscribed to the Google Groups > "Fluent NHibernate" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<fluent-nhibernate%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/fluent-nhibernate?hl=en. > > > -- You received this message because you are subscribed to the Google Groups "Fluent NHibernate" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/fluent-nhibernate?hl=en.
