Hi Chris, Corey managed to prod me into reviewing this stuff and getting it integrated. There was one issue where the unit test relating to setting backfield access on an Any mapping was failing. I've now resolved that.
I'll try to get some feedback from Corey before I ask James to pull these changes through. Paul On Sun, Dec 6, 2009 at 1:42 PM, Chris C <[email protected]> wrote: > Ok, I've added a 3 conventions to cover composite-id, key-property and > key-many-to-one, I've committed them to my access-convention branch if > any one would like to review the changes for me. > > See, > http://github.com/chilversc/fluent-nhibernate/commit/0f7e647e1900b71c2fc8d5ac518e1600268b1a44 > and the previous 2 commits. > > On Nov 29, 4:09 am, Chris C <[email protected]> wrote: > > Ah yes, not sure how I managed that as it was correct at one point. > > > > I've fixed it now, should have been using expectedAccess. > > > > I've also added the remaining tests that were to do and now the only > > two I'm having issues with is thecompositeidand the reference any > > mapping, I can't find a convention that covers these? > > > > On 19 Nov, 07:38, Paul Batum <[email protected]> wrote: > > > > > > > > > Hi Chris, > > > > > Where did you end up with this? As is stands that test you've pointed > to > > > looks a little odd, it has a couple of assertions that seem to assert > that > > > something is equal to itself. > > > > > On Wed, Nov 4, 2009 at 11:40 AM, Chris C <[email protected]> > wrote: > > > > > > Is there a convention that targetscompositekeys that use > > > > WithKeyProperty / reference. It's the key properties and references > > > > I'm actually after in this case, as I'm trying to make the this test > > > > pass: > > > > > > > http://github.com/chilversc/fluent-nhibernate/blob/access-convention/... > > > > > > The failing test is composite_id_is_set. > > > > --~--~---------~--~----~------------~-------~--~----~ > > > > You received this message because you are subscribed to the Google > Groups > > > > "Fluent NHibernate" group. > > > > To post to this group, send email to > [email protected] > > > > To unsubscribe from this group, send email to > > > > [email protected]<fluent-nhibernate%[email protected]><fluent-nhibernate%2Bunsubscr > [email protected]> > > > > For more options, visit this group at > > > >http://groups.google.com/group/fluent-nhibernate?hl=en > > > > -~----------~----~----~----~------~----~------~--~--- > > -- > > You received this message because you are subscribed to the Google Groups > "Fluent NHibernate" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<fluent-nhibernate%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/fluent-nhibernate?hl=en. > > > -- You received this message because you are subscribed to the Google Groups "Fluent NHibernate" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/fluent-nhibernate?hl=en.
