Hi Kevin, Sorry it took me so long to get back to you on this.
1. I can't think of any database-dependent code in FNH. You are quite right that the feature you are suggesting would be a departure in this regard. One possibility would be for us to add the appropriate hooks to FNH for you to implement this functionality in your own application, rather than adding the entire feature to FNH itself. 2. I think it is. As far as I'm concerned, as long as the final output is just mapping files for nhibernate, then anything is fair game. Taking into consideration other aspects such as maintainability, etc. 3. To the best of my knowledge you are the first to suggest it. To be honest my understanding of what you are proposing is still sort of vague to me, but conceptually it makes sense. Paul. On Tue, Feb 16, 2010 at 7:58 PM, Kevin Thiart <kevinthi...@gmail.com> wrote: > Hi Paul > > Where would I put the logic for constructing the text in the > sql-update/insert elements? > It's database-dependent. > It also doesn't have to be used with stored procs, so it will have to > be flexible enough to support other conventions in the future. > > Another question is whether FNH should add good cross-db support for > SPs before NH even does. > Are there other examples of FNH adding features to plain NH other than > the fact that mapping can be automated/convention-based/simplified? > > Is such a feature feasible or even desirable? > Using SPs with NH is a bit of an antipattern, but iBATIS maps to > hand-written SQL queries with relative success so perhaps it isn't > such a bad idea. > > If it makes sense I may decide to start work on this. But progress > will be slow because I'm swamped with work at the moment. > > > So, the tl;dr version: > > 1. Is there other database-dependent logic in FNH? > 2. Is it OK for FNH to add features that NH doesn't directly support? > 3. Does such a feature make sense at all? Am I the first to suggest it? > > > Regards > > Kevin > > -- > You received this message because you are subscribed to the Google Groups > "Fluent NHibernate" group. > To post to this group, send email to fluent-nhibern...@googlegroups.com. > To unsubscribe from this group, send email to > fluent-nhibernate+unsubscr...@googlegroups.com<fluent-nhibernate%2bunsubscr...@googlegroups.com> > . > For more options, visit this group at > http://groups.google.com/group/fluent-nhibernate?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Fluent NHibernate" group. To post to this group, send email to fluent-nhibern...@googlegroups.com. To unsubscribe from this group, send email to fluent-nhibernate+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/fluent-nhibernate?hl=en.