By not using TR, your allowing more flexible markup scenarios. Perhaps to prevent slowing things dow, we scope it to the queue or something more constrained - I would highly recommend not hard baking selector types that cant be overridden.....i hope im not missing something.
Jacob On Wed, Nov 19, 2008 at 2:22 PM, Eli Cochran <[EMAIL PROTECTED]> wrote: > Apologies for the cryptic message earlier, I was in a bit of panic > over my check-in of broken code. > > The broken-ness was just a garden variety typo. > > However, the slowness was because we rephrased our selector for > fileRows from "tr:not(#queue-row-tmplt)" to ":not(#queue-row-tmplt)". > > tr:not(#queue-row-tmplt) means "all *row elements* that do not have an > id of "queue-row-tmplt". > > while > > :not(#queue-row-tmplt) means *any and all* elements that do not have > an id of "queue-row-tmplt". > > so while the former forced jQuery to inspect every row element and > return all but one of those rows, the latter selector forced jQuery to > inspect each and every element in the container and return all but one > of those. > > It's really quite surprising that all it did was slow down. > > - Eli > > > On Nov 19, 2008, at 12:06 PM, Eli Cochran wrote: > > > Hi, > > Somewhere between bringing in some code and refactoring some code > > something got seriously broken. The FileQueueView tests are broken, > > the file progress is broken, and adding files to the Uploader has > > gotten significantly slower. > > > > I have a lead on all these problems and will add fixes after a lunch > > meeting. And I will also follow up with a longer email about why > > things slowed down as it is an interesting lesson in DOM parsing. > > > > - Eli > > > > On Nov 19, 2008, at 11:22 AM, Subversion Database Process wrote: > > > >> ------------------------------------------------------------------------ > >> r6068 | [EMAIL PROTECTED] | 2008-11-19 14:22:11 -0500 (Wed, 19 > >> Nov 2008) | 1 line > >> Changed paths: > >> M /fluid/components/trunk/src/webapp/fluid-components/js/fluid/ > >> uploader2/FileQueueView.js > >> > >> FLUID-1671: Clean and refactoring of code > >> ------------------------------------------------------------------------ > >> _______________________________________________________ > >> Commits mailing list - [EMAIL PROTECTED] > >> To unsubscribe, change settings or access archives, > >> see http://fluidproject.org/mailman/listinfo/commits > > > > . . . . . . . . . . . . . . . . . . > . > > > > Eli Cochran > > user interaction developer > > ETS, UC Berkeley > > > > > > . . . . . . . . . . . . . . . . . . > . > > Eli Cochran > user interaction developer > ETS, UC Berkeley > > > _______________________________________________________ > fluid-work mailing list - [email protected] > To unsubscribe, change settings or access archives, > see http://fluidproject.org/mailman/listinfo/fluid-work > -- Jacob Farber University of Toronto - ATRC Tel: (416) 946-3002 www.fluidproject.org
_______________________________________________________ fluid-work mailing list - [email protected] To unsubscribe, change settings or access archives, see http://fluidproject.org/mailman/listinfo/fluid-work
