Hi Justin and list,

More bug parade reviews:

* FLUID-2017 looks good from a code perspective. There was no reference on the JIRA to a test that shows this issue in action, so I wasn't able to confirm that the functionality is complete.

* FLUID-2224: I committed a fix to this one back on Thursday. All the Uploader tests are passing again. I'm pretty sure Eli reviewed it at the time, but I can't find any reference to it on the JIRA. Double- check with him, but this one looks like it's good to go.

* I reviewed the series of commits that fix FLUID-2179 and FLUID-2192. The Pager is working nicely again in all of the browsers I tested with, and a number of framework improvements came along with this fix. +1 for inclusion in Infusion 0.8.

Further thoughts on Pager:

The recent round of code changes are substantial and wide-ranging. There's still some polish and TLC that I'd like to see go into Pager before we take off the "Preview" sticker (in time for 1.0, I hope). This includes better unit tests, JSLinting, documentation, and some flattening of deeply nested code to improve readability. That said, the Pager has undergone some really great improvements over the past week or two, and it is currently our flagship "renderized" component.

Overall, this seems like it was a pretty great bug parade. The vast majority of the items on your list look squashed. Nice work, everyone!

COlin

---
Colin Clark
Technical Lead, Fluid Project
Adaptive Technology Resource Centre, University of Toronto
http://fluidproject.org

_______________________________________________________
fluid-work mailing list - [email protected]
To unsubscribe, change settings or access archives,
see http://fluidproject.org/mailman/listinfo/fluid-work

Reply via email to