http://issues.fluidproject.org/secure/ManageAttachments.jspa?id=12646

I've cleaned it out further and noted the revisions when I reposted attachment.


On 26-Mar-09, at 3:29 PM, Jacob Farber wrote:

Sure - you could just delete the patch that's there now, and upload a new one.
I would be happy to apply it :)

-----Original Message-----
From: electBlake [mailto:[email protected]]
Sent: Thursday, March 26, 2009 3:27 PM
To: Jacob Farber
Cc: fluid-work List
Subject: Re: VULAB-191 - Code Review Request

Hey Jacob!

Thanks for the review :)

Yeah, I can delete it - no need for it. I've kept abunch of random
little snippets from the days where I tried ajaxing this system. This
is one such snippet. Specifically, the commented code bridges php POST
data with javascript.

I'll delete the commented code and repost the patch?


On 26-Mar-09, at 3:23 PM, Jacob Farber wrote:

Hi Blake - did you have to keep the commented code, or would you be
able to delete it and rely on svn to just roll that back if you end
up needing it again?

-----Original Message-----
From: [email protected] 
[mailto:[email protected]
] On Behalf Of electBlake
Sent: Thursday, March 26, 2009 3:06 PM
To: fluid-work List
Subject: VULAB-191 - Code Review Request

Hello Hello,

vulab.admin.js is the core javascript file that controls the js of the admin system for VULab, and here is a small patch that cleans up a few things and adds in a design element (curvey corners) that johnc added.

http://issues.fluidproject.org/browse/VULAB-191

Thanks again,
- Blake
_______________________________________________________
fluid-work mailing list - [email protected]
To unsubscribe, change settings or access archives,
see http://fluidproject.org/mailman/listinfo/fluid-work

_______________________________________________________
fluid-work mailing list - [email protected]
To unsubscribe, change settings or access archives,
see http://fluidproject.org/mailman/listinfo/fluid-work

_______________________________________________________
fluid-work mailing list - [email protected]
To unsubscribe, change settings or access archives,
see http://fluidproject.org/mailman/listinfo/fluid-work

Reply via email to