Hi Justin,

I saw your patch on the JIRA issue. Thanks for tracking down and fixing this 
issue. It's something I should have caught in code review for the last fix.

I'm wondering whether or not this issue really does require a full re-test of 
the components you mentioned? Would it not be sufficient to write a unit test 
that shows the bug without the patch and passes once the patch had been 
applied? And then to follow that up with a reasonably quick overview test of 
the Reorderer and other keyboard-a11y code?

You're the King, so I'm happy to defer to your judgement here. I'm hoping this 
might be a case where we can use unit testing to reduce our QA efforts 
effectively.

Thoughts?

Colin

On 2010-04-13, at 5:23 PM, Justin Obara wrote:

> It appears that the keyboard a11y plugin is throwing errors under certain 
> conditions. 
> http://issues.fluidproject.org/browse/FLUID-3647
> 
> This looks like it won't be too difficult to fix but will mean we will have 
> to retest anything that depends on the keyboard a11y code.
> 
>       - reorderer
>       - inline edit
>       - unit tests for reorderer, inline edit, and keyboard a11y
> 
> Unfortunately this will likely set us back a bit and will probably mean we 
> will be releasing infusion 1.2 late wednesday or thursday. 

---
Colin Clark
Technical Lead, Fluid Project
http://fluidproject.org

_______________________________________________________
fluid-work mailing list - [email protected]
To unsubscribe, change settings or access archives,
see http://fluidproject.org/mailman/listinfo/fluid-work

Reply via email to