Hi Justin - sorry not to get to this until now. I've had a general look
over the code and it is looking pretty good, especially the use of the
new "anchorInfo" structure. Perhaps we should just put a comment on the
component tree generation code to explain that it is the way it is
waiting for framework support for antigens and a reference to
FLUID-4261. Unfortunately the code responsible for the level skipping is
a bit too intricate for me to parse right now since I am heading out,
but I will try to have a look at it whilst on holiday. Hopefully I will
have some kind of email contact over the next couple of days -
Cheers,
Antranig.
On 07/06/2011 21:37, Justin Obara wrote:
Hi Antranig,
Could you please take a quick look to see what's up with this. Sorry
that I don't have any proper unit tests yet. I've been quite distracted
and haven't had a chance to come back to this in a while.
The branch:
https://github.com/jobara/infusion/tree/FLUID-4209
So the issue is that for the ToC if there is a level that gets skipped,
instead of being blank it is filled in by the parent content.
so you would get something like
Humans
- Humans
- - Catts
Instead of
Humans
-- Catts
You can run the demo to see this in action.
https://github.com/jobara/infusion/blob/FLUID-4209/src/webapp/standalone-demos/table-of-contents/html/TableOfContents.html
If you also have time to do another general review that would be great too.
Thanks
Justin
On 2011-05-26, at 3:11 PM, Justin Obara wrote:
_______________________________________________________
fluid-work mailing list - [email protected]
To unsubscribe, change settings or access archives,
see http://fluidproject.org/mailman/listinfo/fluid-work
