Hi Antranig, thanks for the comments. All has been done and your further review
please. More comments inline.
> Thanks for the comment on this impl which refers readers to the WebVTT or
> json format - could we have a link which explicitly directs the reader to the
> standard in question where the definition of this time format appears (I
> hope!) - which is the "json format"?
The caption file in json that is currently used in the video player is made up
by ourselves, which doesn't have any published standard for the users to
follow. However, the timestamp part is fortunately WebVTT format compatible. I
have added the link that points to there. Thanks for mentioning about the
standard, while reading it, I noticed the hour portion ("hh:") is actually
optional rather than mandatory. This finding has been implemented in the
function.
BTW, the self-digested json caption file will soon be replaced by the
captionator and its supported WebVTT file format.
> Good work on removing all references to the HTML5 driver from this file. I am
> puzzled about why and how the interval Ids become converted to strings, e.g.
> "0" rather than the numerical indexes that they doubtless are in the interval
> list. I can't easily see where in the implementation of either the component
> or the test cases this occurs.... this shouldn't happen as far as I can see.
> Can you discover where it happens and explain it? (And preferably, make it go
> away : P)
Yes, the stringly liked interval Ids have been fixed with fluid.find. :)
>
>
> On 06/02/2012 14:42, Li, Cindy wrote:
>> Hi Antranig,
>>
>> Thanks for taking the time to share the thoughts and explain in such a
>> detail.
>>
>> Your suggestions have been applied. The pull request for this branch is
>> ready for another round of review,
>>
>> https://github.com/fluid-project/videoPlayer/pull/13
>>
>> Cheers!
>>
>> Cindy
>>
_______________________________________________________
fluid-work mailing list - [email protected]
To unsubscribe, change settings or access archives,
see http://lists.idrc.ocad.ca/mailman/listinfo/fluid-work
