Unfortunately we didn't get round to our architecture chat re. the captionator in the last couple of days...
shamefully for open source morals, michelled and I had a private chat yesterday in which we considered that
returning the captions.sources option to being an array to match video.sources was a sound idea, especially
bearing in mind that the authoritative representation of the caption language is now present as the
"srcland" property inside the structure.
That change being done I'm happy we can push, but thought we should have a final check for any objections
since it is a significant API change to the component. This would let us simplify the implementation
moderately.
For reference, a sample defaults structure appears at
https://github.com/xOZx/videoPlayer/blob/FLUID-4554/demos/VideoPlayer.html
I have a suggestion that both "video" and "captions" structures (except for "currentTrack", etc.) be moved
out of the model area of this component's options to top level, since they are "not ordinarily modifiable"
during the lifetime of the component. Actually, this may be an error in the current implementation since
this seems to be the position that parts of the implementation are expecting to find the captions - e.g.
var captions = that.options.captions || {};
Antranig
_______________________________________________________
fluid-work mailing list - [email protected]
To unsubscribe, change settings or access archives,
see http://lists.idrc.ocad.ca/mailman/listinfo/fluid-work
