This looks a lot better Alex! I think it should go into the demo. Do you want to put in the appropriate comments, particularly for the captionator hacks, and push this to demo?
Michelle On 2012-02-26, at 1:41 PM, Novak, Alexey wrote: > Hi there, > > Thanks to your changes Michelle, good work. I managed to modify your code to > make controller bar to slide nicely with captions :) > Branch is available here: > https://github.com/xOZx/videoPlayer/tree/FLUID-4616-experimental > > Basically, placed both controller bar and caption area into one div, as you > Michelle mentioned. Plus remembered exactly what CSS styling I applied on > Friday to make caption area and controller area to be in a div one on top > another. > > Had to change captionator.js code and change CSS styles. Let me know what do > you think. > It is an experimental branch so I did not put comments into captionator and > more since want to know your opinion first. > > Alex > > > ________________________________________ > From: [email protected] > [[email protected]] on behalf of Novak, Alexey > [[email protected]] > Sent: Sunday, February 26, 2012 12:36 PM > To: Michelle D'Souza; Fluid Work > Subject: RE: Hiding and showing the controllers > > It looks pretty decent to be honest even with captions jumping up and down... > although, sad to mention, that positioning is not stable. Couple of times I > managed to make captions appear right beneath the controller bar. > Also all labels are shown beneath the controller bar as well, maybe it is the > time to use z-index for the alts? > If we are going to use this branch maybe we need to position captions a > little bit higher so that when you use UIO captions do not overlap with the > controller bar. > > Ugh.. captionator positioning is a real pain. > The creator finally contacted me, wondering if he could make changes in his > code to use em instead of points or fix the positioning somehow :S > > Alex > > > > ________________________________________ > From: [email protected] > [[email protected]] on behalf of Michelle D'Souza > [[email protected]] > Sent: Sunday, February 26, 2012 12:04 PM > To: Fluid Work > Subject: Hiding and showing the controllers > > Hi, > > I've just pushed a branch to my repo which hides and shows the controllers on > mouse over. https://github.com/michelled/videoPlayer/tree/FLUID-4619 > > There are a couple bugs in this interaction right now that aren't trivial to > fix. > > 1) The captions don't slide with the controllers - instead they jump up and > down. I think the best solution to this is to change the way the styling on > the captions is done. This is actually quite a bit of work and probably > involves forking Captionator. > > 2) When navigating with the keyboard, the controllers show when the video > gets focus but they don't hide after tabbing away from the video player. The > issue here is that when the video loses focus, it's because the first > controller gets focus. At this point we obviously don't want to hide the > controllers. What I need to know when the next thing after the video player > gets focus. Perhaps this is a case for deadMansBlur? > > I'm not sure if this branch is currently an improvement of the demo branch. > Could someone please review the interaction and let me know what you think? > > Thanks, > > Michelle > > > _______________________________________________________ > fluid-work mailing list - [email protected] > To unsubscribe, change settings or access archives, > see http://lists.idrc.ocad.ca/mailman/listinfo/fluid-work > _______________________________________________________ > fluid-work mailing list - [email protected] > To unsubscribe, change settings or access archives, > see http://lists.idrc.ocad.ca/mailman/listinfo/fluid-work _______________________________________________________ fluid-work mailing list - [email protected] To unsubscribe, change settings or access archives, see http://lists.idrc.ocad.ca/mailman/listinfo/fluid-work
