[ 
https://issues.apache.org/jira/browse/FLUME-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083042#comment-13083042
 ] 

[email protected] commented on FLUME-706:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1467/
-----------------------------------------------------------

Review request for Flume.


Summary
-------

rough draft of a different approach to tackling FLUME-706


This addresses bug flume-706.
    https://issues.apache.org/jira/browse/flume-706


Diffs
-----

  flume-core/src/main/java/com/cloudera/flume/agent/FlumeNode.java b8f2b67 
  flume-core/src/main/java/com/cloudera/flume/agent/LivenessManager.java 
c72a626 
  flume-core/src/main/java/com/cloudera/flume/agent/LogicalNode.java 3f64238 
  flume-core/src/main/java/com/cloudera/flume/agent/LogicalNodeManager.java 
b3f96f2 
  flume-core/src/main/java/com/cloudera/flume/conf/FlumeConfigData.java 9e660cc 
  
flume-core/src/test/java/com/cloudera/flume/agent/TestAgentCloseNoDeadlock.java 
e1353b8 
  flume-core/src/test/java/com/cloudera/flume/agent/TestLogicalNodeManager.java 
0fd4bc6 
  
flume-core/src/test/java/com/cloudera/flume/agent/diskfailover/TestDiskFailoverBehavior.java
 831eca3 

Diff: https://reviews.apache.org/r/1467/diff


Testing
-------

running tests currently, need to add tests and cleanup still.


Thanks,

jmhsieh



> Flume nodes launch duplicate logical nodes
> ------------------------------------------
>
>                 Key: FLUME-706
>                 URL: https://issues.apache.org/jira/browse/FLUME-706
>             Project: Flume
>          Issue Type: Bug
>          Components: Master, Node
>    Affects Versions: v0.9.5
>            Reporter: E. Sammer
>            Assignee: E. Sammer
>            Priority: Critical
>             Fix For: v0.9.5
>
>         Attachments: 
> 0001-FLUME-706-Flume-nodes-launch-duplicate-logical-nodes.patch, FLUME-706.log
>
>
> When submitting a config command to the flume master, it seems as if the 
> downstream node attempts to load the config twice.
> In a test case, starting a single master and a single node, I submitted a 
> "config node rpcSource(12345) console". The node sees the config change on 
> the next heartbeat and updates its config and starts the thrift source on 
> port 12345. Immediately after, it logs "Taking another heartbeat" (DEBUG) and 
> attempts to create another logical node with the same config. This leads to 
> thrift errors in bind() and "Could not create ServerSocket on address ...". 
> Looking at the root cause in a debugger (thrift swallows the original 
> exception) I can see it's an "Address already in use" IOException.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to