[
https://issues.apache.org/jira/browse/FLUME-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086346#comment-13086346
]
[email protected] commented on FLUME-742:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1543/#review1497
-----------------------------------------------------------
Ship it!
lgtm.
- jmhsieh
On 2011-08-17 04:21:33, jmhsieh wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1543/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-17 04:21:33)
bq.
bq.
bq. Review request for Flume, Arvind Prabhakar, jmhsieh, and Tom White.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Posted on review board for Tom White. (use /trunk/ as base dir, or use
flume-git and post gt post).
bq.
bq. TestAvroSinks apparently is failing but Maven is not reporting the
failure! This fixes behavior of the sink and updates to make a valid test.
bq.
bq.
bq. This addresses bug FLUME-742.
bq. https://issues.apache.org/jira/browse/FLUME-742
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/trunk/flume-core/src/main/java/com/cloudera/flume/handlers/avro/AvroEventSink.java
1157304
bq.
/trunk/flume-core/src/test/java/com/cloudera/flume/handlers/avro/TestAvroSinks.java
1157304
bq.
bq. Diff: https://reviews.apache.org/r/1543/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tom ran TestAvroSinks
bq.
bq.
bq. Thanks,
bq.
bq. jmhsieh
bq.
bq.
> TestAvroSinks fails
> -------------------
>
> Key: FLUME-742
> URL: https://issues.apache.org/jira/browse/FLUME-742
> Project: Flume
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Attachments: FLUME-742.patch, FLUME-742.patch
>
>
> The following appears in the log
> {noformat}
> 2011-08-12 21:21:48,784 [Thread-13] INFO avro.AvroEventSink: AvroEventSink
> open on port 35854
> 2011-08-12 21:21:48,863 [Thread-13] INFO debug.MemorySinkSource: Closing mem
> source sink that has 25 elements
> 2011-08-12 21:21:48,863 [Thread-13] INFO avro.AvroEventSink: AvroEventSink on
> port 35854 closed
> Exception in thread "Thread-13" java.lang.NullPointerException
> at
> com.cloudera.flume.handlers.avro.AvroEventSink.getSentBytes(AvroEventSink.java:116)
> at
> com.cloudera.flume.handlers.avro.TestAvroSinks$3.run(TestAvroSinks.java:196)
> {noformat}
> Then the test (testManyThreadsAvroSend) times out.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
