----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1467/ -----------------------------------------------------------
(Updated 2011-08-17 19:55:38.022879) Review request for Flume, Arvind Prabhakar and Eric Sammer. Changes ------- Updated to clean up exception handling when a spawn fails, and with real unit test that tests to root problem. Look at the diff between #1 and #2 to see improved exception handling and added test case. Summary (updated) ------- commit 34b0ada18f38d82b8acee4c2ec1a5b6693e524ea Author: Jonathan Hsieh <[email protected]> Date: Wed Aug 17 10:35:22 2011 -0700 FLUME-706: Flume nodes launch duplicate logical nodes When a logical node is being spawned for the first time we attempt to load the config of the node. Unfortunately, we would subsequently load it again and spawn a second driver thread because we neglected to update the last good config version. This fixes the problem by making sure that value gets updated on the first attempt. We also update error handling so that a failure of signle logical node spawn only affects that node. This addresses bug flume-706. https://issues.apache.org/jira/browse/flume-706 Diffs (updated) ----- flume-core/src/main/java/com/cloudera/flume/agent/FlumeNode.java b8f2b67 flume-core/src/main/java/com/cloudera/flume/agent/LivenessManager.java c72a626 flume-core/src/main/java/com/cloudera/flume/agent/LogicalNode.java 3f64238 flume-core/src/main/java/com/cloudera/flume/agent/LogicalNodeManager.java b3f96f2 flume-core/src/main/java/com/cloudera/flume/conf/FlumeConfigData.java 9e660cc flume-core/src/test/java/com/cloudera/flume/agent/TestAgentCloseNoDeadlock.java e1353b8 flume-core/src/test/java/com/cloudera/flume/agent/TestLogicalNodeManager.java 0fd4bc6 flume-core/src/test/java/com/cloudera/flume/agent/diskfailover/TestDiskFailoverBehavior.java 831eca3 flume-core/src/test/java/com/cloudera/flume/shell/TestFlumeShell.java f81b190 Diff: https://reviews.apache.org/r/1467/diff Testing (updated) ------- Added new test, it passes. Currently running full test suite. Thanks, jmhsieh
