----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1949/#review1963 -----------------------------------------------------------
Ship it! LGTM. - Roman On 2011-09-19 00:04:07, jmhsieh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1949/ > ----------------------------------------------------------- > > (Updated 2011-09-19 00:04:07) > > > Review request for Flume, Arvind Prabhakar and Roman Shaposhnik. > > > Summary > ------- > > commit b34670902d4c667f98ffe7e619c436148c89e000 > Author: Jonathan Hsieh <[email protected]> > Date: Sun Sep 18 11:05:42 2011 -0700 > > FLUME-580: Flume needs to be consistent with autodiscovery of Hadoop > compres > > - Adds native paths for hadoop native codec support > > > This addresses bug FLUME-580. > https://issues.apache.org/jira/browse/FLUME-580 > > > Diffs > ----- > > bin/flume 183cf70 > > Diff: https://reviews.apache.org/r/1949/diff > > > Testing > ------- > > Built and ran > > flume sink 'collectorSource("file:///tmp/snappy", "foo", 10000, > seqfile("snappy")' > > typed some stuff at the console, then ^D. > > /tmp/snappy dir had files that were snappy codec compressed. > > > Thanks, > > jmhsieh > >
