[
https://issues.apache.org/jira/browse/FLUME-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112866#comment-13112866
]
Jonathan Hsieh commented on FLUME-766:
--------------------------------------
seems fine, please add some comments on the top of the file about
FLUME_PID_DIR, MASTERPID, NODEPID, and FLUME_IDENT_STRING?
Thanks, Jon.
> the location and name of the flume's PID file needs to be tweakable
> -------------------------------------------------------------------
>
> Key: FLUME-766
> URL: https://issues.apache.org/jira/browse/FLUME-766
> Project: Flume
> Issue Type: Bug
> Components: Shell
> Affects Versions: v0.9.4
> Reporter: Roman Shaposhnik
> Priority: Minor
> Attachments: FLUME-766-1.patch.txt, FLUME-766.patch.txt
>
>
> Currently it is hardcoded in flume shell script:
> MASTERPID=${FLUME_PID_DIR:="/tmp"}/flumemaster.pid
> .....
> MASTER_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID $WATCHDOG_CLASS"
> MASTERI_WATCHDOG="java ${JOPTS} -Dpid=$$ -Dpidfile=$MASTERPID
> $WATCHDOG_CLASS"
> NODE_WATCHDOG="java ${JOPTS} -Dpid=$$
> -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
> NODEI_WATCHDOG="java ${JOPTS} -Dfwdstdin=true -Dpid=$$
> -Dpidfile=${FLUME_PID_DIR}/flumenode-$$.pid $WATCHDOG_CLASS"
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
