[ 
https://issues.apache.org/jira/browse/FLUME-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133749#comment-13133749
 ] 

Hudson commented on FLUME-818:
------------------------------

Integrated in flume-728 #54 (See [https://builds.apache.org/job/flume-728/54/])
    FLUME-818: PropertiesFileConfigurationProvider doesn't properly log 
exceptions

esammer : http://svn.apache.org/viewvc/?view=rev&rev=1187968
Files : 
* 
/incubator/flume/branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java

                
> PropertiesFileConfigurationProvider doesn't properly log exceptions
> -------------------------------------------------------------------
>
>                 Key: FLUME-818
>                 URL: https://issues.apache.org/jira/browse/FLUME-818
>             Project: Flume
>          Issue Type: Bug
>    Affects Versions: NG alpha 1
>            Reporter: E. Sammer
>            Assignee: E. Sammer
>            Priority: Trivial
>             Fix For: NG alpha 2
>
>
> In the exception handling logic of PropertiesFileConfigurationProvider, we 
> accidentally get the incorrect overridden method in slf4j. This is a silly 
> interface issue in slf4j. For reference, here's the cause.
> SLF4J allows parameterized log messages such as logger.error("Bad value: {}", 
> value). It also has overridden methods that know how to print exceptions like 
> logger.error("Caught the exception", ex). Note that the latter is not a 
> parameter, but a separate argument. There's a method signature of all logging 
> methods that looks like error(String, Object, Object) for a parameterized 
> format string with two parameters. Unfortunately, this matches 
> error("Received value {} but caught an exception", value, ex) and does *NOT* 
> do what is intended. Boo hiss. I'm guilty of making this mistake endlessly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to