----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2943/#review3578 -----------------------------------------------------------
Ship it! I'm embarrassed I never got back around to fixing these things. lgtm. - Eric On 2011-11-27 06:52:44, Arvind Prabhakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2943/ > ----------------------------------------------------------- > > (Updated 2011-11-27 06:52:44) > > > Review request for Flume and Eric Sammer. > > > Summary > ------- > > This change cleans up some code in LoggerSink, RollingFileSink and > NetcatSource dealing with transaction handling. > > The problem highlighted in FLUME-822 is not reproducible so far and my hope > is that this clean up code will help address any isolated cases that could > cause it. > > > This addresses bug FLUME-822. > https://issues.apache.org/jira/browse/FLUME-822 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/sink/LoggerSink.java f098604 > flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java > 5632b75 > flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java > f9251a6 > > Diff: https://reviews.apache.org/r/2943/diff > > > Testing > ------- > > Ran all the tests successfully. > > > Thanks, > > Arvind > >
