[
https://issues.apache.org/jira/browse/FLUME-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160189#comment-13160189
]
[email protected] commented on FLUME-822:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2943/#review3578
-----------------------------------------------------------
Ship it!
I'm embarrassed I never got back around to fixing these things. lgtm.
- Eric
On 2011-11-27 06:52:44, Arvind Prabhakar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2943/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-27 06:52:44)
bq.
bq.
bq. Review request for Flume and Eric Sammer.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This change cleans up some code in LoggerSink, RollingFileSink and
NetcatSource dealing with transaction handling.
bq.
bq. The problem highlighted in FLUME-822 is not reproducible so far and my
hope is that this clean up code will help address any isolated cases that could
cause it.
bq.
bq.
bq. This addresses bug FLUME-822.
bq. https://issues.apache.org/jira/browse/FLUME-822
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/sink/LoggerSink.java
f098604
bq. flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java
5632b75
bq. flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java
f9251a6
bq.
bq. Diff: https://reviews.apache.org/r/2943/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran all the tests successfully.
bq.
bq.
bq. Thanks,
bq.
bq. Arvind
bq.
bq.
> JDBC channel lock acquisition failure during take()
> ---------------------------------------------------
>
> Key: FLUME-822
> URL: https://issues.apache.org/jira/browse/FLUME-822
> Project: Flume
> Issue Type: Bug
> Components: Channel
> Affects Versions: NG alpha 1
> Reporter: E. Sammer
> Assignee: Arvind Prabhakar
> Priority: Blocker
> Fix For: NG alpha 2
>
> Attachments: FLUME-822-1.patch, flume-jdbc-lock-failure.log
>
>
> The jdbc channel implementation (using Derby) results in a lock acquisition
> error upon take().
> It appears as if the event is successfully inserted by the source, but the
> sink fails to receive the event in the allotted time. The configuration used
> was as follows.
> ==
> localhost.sources = avro nc
> localhost.sinks = logger log2
> localhost.channels = ch1 ch2
> localhost.channels.ch1.type = memory
> localhost.channels.ch1.capacity = 10000
> localhost.sources.avro.type = avro
> localhost.sources.avro.bind = 0.0.0.0
> localhost.sources.avro.port = 41414
> localhost.sources.avro.channels = ch1
> localhost.sinks.logger.type = logger
> localhost.sinks.logger.channel = ch1
> #
> localhost.channels.ch2.type = jdbc
> localhost.sources.nc.type = netcat
> localhost.sources.nc.bind = 0.0.0.0
> localhost.sources.nc.port = 41415
> localhost.sources.nc.name = nc
> localhost.sources.nc.channels = ch2
> localhost.sinks.log2.type = logger
> localhost.sinks.log2.channel = ch2
> ==
> The path in use is nc(netcat) -> ch2(jdbc) -> log2(logger) with minimal
> configuration. I'll attach log output shortly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
