[
https://issues.apache.org/jira/browse/FLUME-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160195#comment-13160195
]
[email protected] commented on FLUME-821:
-----------------------------------------------------
bq. On 2011-11-30 18:04:58, Eric Sammer wrote:
bq. > Maybe a tweak on the log message level - up to you. Otherwise, lgtm!
Thanks for the reivew Eric. My comments follow.
bq. On 2011-11-30 18:04:58, Eric Sammer wrote:
bq. >
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java,
line 120
bq. > <https://reviews.apache.org/r/2938/diff/1/?file=60141#file60141line120>
bq. >
bq. > Is this really a warning or just INFO?
Will change it before commit.
bq. On 2011-11-30 18:04:58, Eric Sammer wrote:
bq. >
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java,
line 143
bq. > <https://reviews.apache.org/r/2938/diff/1/?file=60140#file60140line143>
bq. >
bq. > Should all of these constants (at some future point) be broken out
into an external properties file for simpler updating? Just food for thought.
This is an implementation specific constant. Hence it is private scoped within
the schema handler.
- Arvind
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2938/#review3579
-----------------------------------------------------------
On 2011-11-27 05:25:12, Arvind Prabhakar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2938/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-27 05:25:12)
bq.
bq.
bq. Review request for Flume and Prasad Mujumdar.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This change introduces the ability to create indexes while schema creation
via the derby schema handler. The implementation defaults to the creation of
indexes which can be turned off via configuration.
bq.
bq.
bq. This addresses bug FLUME-821.
bq. https://issues.apache.org/jira/browse/FLUME-821
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java
7e0b3ac
bq.
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java
7b29c7d
bq.
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java
c1bc400
bq.
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/MySQLSchemaHandler.java
1065ef9
bq.
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/SchemaHandler.java
68946c9
bq.
flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java
9ce6d16
bq.
bq. Diff: https://reviews.apache.org/r/2938/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All unit tests run successfully.
bq.
bq.
bq. Thanks,
bq.
bq. Arvind
bq.
bq.
> Derby schema handler should create the necessary indexes for fast lookups.
> --------------------------------------------------------------------------
>
> Key: FLUME-821
> URL: https://issues.apache.org/jira/browse/FLUME-821
> Project: Flume
> Issue Type: Improvement
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Fix For: NG alpha 2
>
> Attachments: FLUME-821-1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
