[ 
https://issues.apache.org/jira/browse/FLUME-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160200#comment-13160200
 ] 

[email protected] commented on FLUME-816:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2930/#review3582
-----------------------------------------------------------

Ship it!


lgtm!

- Eric


On 2011-11-24 20:22:06, Arvind Prabhakar wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2930/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-11-24 20:22:06)
bq.  
bq.  
bq.  Review request for Flume and Eric Sammer.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Fix for FLUME-816
bq.  
bq.  
bq.  This addresses bug FLUME-816.
bq.      https://issues.apache.org/jira/browse/FLUME-816
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    .gitignore c319325 
bq.    flume-ng-channels/flume-jdbc-channel/pom.xml 8665eee 
bq.  
bq.  Diff: https://reviews.apache.org/r/2930/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Ran all JDBC channel tests on a different system where I was able to see 
the OOM errors. With this change, the tests pass.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Arvind
bq.  
bq.


                
> TestJdbcChannelProvider throws OOME based on RNG values
> -------------------------------------------------------
>
>                 Key: FLUME-816
>                 URL: https://issues.apache.org/jira/browse/FLUME-816
>             Project: Flume
>          Issue Type: Bug
>          Components: Technical Debt, Test
>    Affects Versions: NG alpha 1
>            Reporter: E. Sammer
>            Assignee: Arvind Prabhakar
>             Fix For: NG alpha 2
>
>         Attachments: FLUME-816-1.patch
>
>
> TestJdbcChannelProvider uses a random number to test header overflow. This 
> causes the JVM running the tests to sometimes die from an OOME. We should cap 
> the test so overflows the header table value field size but stays within a 
> reasonable limit. I've been able to verify this by increasing the maven test 
> JVM heap size to values > 128MB (or more).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to