> On 2011-11-30 17:58:44, Eric Sammer wrote: > > flume-ng-node/src/main/java/org/apache/flume/node/Application.java, lines > > 135-136 > > <https://reviews.apache.org/r/2945/diff/2/?file=60172#file60172line135> > > > > At some point I think we should have a separate properties file for > > "static" agent level configuration like this. My guess is that there will > > be other global configuration in the future.
Agreed. I used the scheme that was outlined in the JIRA discussion. However, once we have service infrastructure, it makes sense to separate out such details into their own separate package/subsystem. - Arvind ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2945/#review3577 ----------------------------------------------------------- On 2011-11-27 21:49:47, Arvind Prabhakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2945/ > ----------------------------------------------------------- > > (Updated 2011-11-27 21:49:47) > > > Review request for Flume and Eric Sammer. > > > Summary > ------- > > Based on the discussion in FLUME-823, this patch implements the fail-fast > scenario for missing configuration file when invoked from the command line. > In order to circumvent this check the system property > "flume.called.from.service" should be set to a non-null value. > > > This addresses bug FLUME-823. > https://issues.apache.org/jira/browse/FLUME-823 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/Constants.java PRE-CREATION > flume-ng-node/src/main/java/org/apache/flume/node/Application.java eabeec1 > > Diff: https://reviews.apache.org/r/2945/diff > > > Testing > ------- > > Manually verified that if the file specified does not exist the process > exits. If the file is specified but does not contain valid configuration for > the node being configured, a warning is printed on the console. > > > Thanks, > > Arvind > >
