[ 
https://issues.apache.org/jira/browse/FLUME-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160498#comment-13160498
 ] 

[email protected] commented on FLUME-814:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2701/
-----------------------------------------------------------

(Updated 2011-12-01 00:22:45.995318)


Review request for Arvind Prabhakar and Eric Sammer.


Changes
-------

Update the patch to maintain consistent state for enclosed transactions in 
error cases. 


Summary
-------

A new fanout channel is added that contains list of underlying channels and 
performs the given operation on all those. A new method added to channelfactory 
to create the fanout channel from a list of channels. One can specify a comma 
separated list of channels for a sink to create the fanout  


This addresses bug Flume-814.
    https://issues.apache.org/jira/browse/Flume-814


Diffs (updated)
-----

  flume-ng-core/src/main/java/org/apache/flume/ChannelFactory.java 23194a9 
  
flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 
8a3ec56 
  flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java 
PRE-CREATION 
  flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java 
4d8313f 
  flume-ng-core/src/test/java/org/apache/flume/channel/TestFanoutChannel.java 
PRE-CREATION 
  
flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java
 975eafd 
  flume-ng-node/src/main/java/org/apache/flume/node/Application.java 8b93e59 

Diff: https://reviews.apache.org/r/2701/diff


Testing
-------

ran all unit tests, added new test for the fanout channel


Thanks,

Prasad


                
> Add support for multiple channels to sources
> --------------------------------------------
>
>                 Key: FLUME-814
>                 URL: https://issues.apache.org/jira/browse/FLUME-814
>             Project: Flume
>          Issue Type: New Feature
>          Components: Sinks+Sources
>    Affects Versions: NG alpha 1
>            Reporter: E. Sammer
>            Assignee: Prasad Mujumdar
>             Fix For: NG alpha 2
>
>         Attachments: FLUME-814.patch
>
>
> Flume NG's architecture and configuration claim sources support multiple 
> channels but this isn't currently true. The current implementation limits 
> sources to a single channel which precludes fanout behavior.
> This will be a fairly invasive change as it impacts the Source interface.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to