[
https://issues.apache.org/jira/browse/FLUME-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162891#comment-13162891
]
[email protected] commented on FLUME-858:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3010/#review3621
-----------------------------------------------------------
Ship it!
lgtm
- Prasad
On 2011-12-05 16:17:28, Jarek Cecho wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3010/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-05 16:17:28)
bq.
bq.
bq. Review request for Flume and Eric Sammer.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I've simply changed operator == to calling method equals().
bq.
bq.
bq. This addresses bug FLUME-858.
bq. https://issues.apache.org/jira/browse/FLUME-858
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSWriterFactory.java
1205921
bq.
bq. Diff: https://reviews.apache.org/r/3010/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. No tests for this class are available yet (actually it would be great idea
to create them :-D), however I did test it on my testing cluster.
bq.
bq.
bq. Thanks,
bq.
bq. Jarek
bq.
bq.
> HDFSWriterFactory is using operation == for string comparison
> -------------------------------------------------------------
>
> Key: FLUME-858
> URL: https://issues.apache.org/jira/browse/FLUME-858
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: NG alpha 1, NG alpha 2
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Priority: Minor
> Fix For: NG alpha 3
>
> Attachments: FLUME-858.patch
>
>
> HDFSWriterFactory is using operator == for string comparison which makes
> other non default file types unaccessible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
