> On 2011-12-05 17:31:54, Prasad Mujumdar wrote: > > lgtm
Thank you very much for the review, path is already submitted to JIRA, so feel free to commit it :-) Jarcec - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3010/#review3621 ----------------------------------------------------------- On 2011-12-05 16:17:28, Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3010/ > ----------------------------------------------------------- > > (Updated 2011-12-05 16:17:28) > > > Review request for Flume and Eric Sammer. > > > Summary > ------- > > I've simply changed operator == to calling method equals(). > > > This addresses bug FLUME-858. > https://issues.apache.org/jira/browse/FLUME-858 > > > Diffs > ----- > > > /branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSWriterFactory.java > 1205921 > > Diff: https://reviews.apache.org/r/3010/diff > > > Testing > ------- > > No tests for this class are available yet (actually it would be great idea to > create them :-D), however I did test it on my testing cluster. > > > Thanks, > > Jarek > >
