Hi Eric, I've followed the instructions on the wiki and submitted a patch.
The only step I was not able to do was to assign the Jira to me: "Assign the issue to yourself in the JIRA. If you cannot, ask one of the project administrators to add you as a contributor." Can you please help me arrange this. Thanks Regards Vibul On 8 December 2011 10:33, Eric Sammer <[email protected]> wrote: > That would be great! Give it a shot and let us know if you have any > questions. > > On Wed, Dec 7, 2011 at 3:11 PM, Vibul Imtarnasan <[email protected]> wrote: > > > Hi Eric, > > > > I created the ticket: > > > > Timestamp header be a standard part of an event > > ----------------------------------------------- > > > > Key: FLUME-872 > > URL: https://issues.apache.org/jira/browse/FLUME-872 > > Project: Flume > > Issue Type: Improvement > > Components: Sinks+Sources > > Affects Versions: NG alpha 2 > > Environment: All > > Reporter: Vibul Imtarnasan > > > > > > Are you accepting code contributions at this point in the flume NG > project? > > If so, are the instructions at > > https://cwiki.apache.org/FLUME/how-to-contribute.html still applicable? > > > > This is something I can look at if you want. > > > > Regards > > Vibul > > > > > > On 7 December 2011 13:29, Eric Sammer <[email protected]> wrote: > > > > > Hey Vibul: > > > > > > On Tue, Dec 6, 2011 at 6:17 PM, Vibul Imtarnasan <[email protected]> > > wrote: > > > > > > > Hi, > > > > > > > > I'm new to Flume NG and am starting to familiarizing myself with the > > code > > > > using https://cwiki.apache.org/FLUME/getting-started.html. > > > > > > > > I am using Eclipse Indigo Service Release 1 and imported the maven > > > project. > > > > > > > > I found that I had to add the following to flume-core pom.xml to get > > > > m2eclipse plugin working (note that running "mvn package" > > > > outside eclipse works fine). > > > > > > > > > > > <snip> > > > > > > Yea, this is due to the new way that m2eclipse works. It's really > > > confusing. I haven't committed the exclusion to the repo for fear it > will > > > break other tools (like Jenkins). It's unclear to me what it does > > (although > > > the docs say it shouldn't break anything - I'm skeptical). > > > > > > > > > > > > > > I also had to add target/generated-sources/arvo in flume-ng-core as a > > > > source path. > > > > > > > > > > It depends on the exact order of events you use to set up the project. > I > > > also use Eclipse (for Java at least) and I found that if I right click > > the > > > project and select "Maven -> Update Project Configuration" it will > > properly > > > set up the generated the source directories for the generated code. > This > > is > > > because m2e doesn't run the generate-sources lifecycle phase of Maven > > > normally or some such thing. > > > > > > An entirely different approach (that I think Arvind uses) is to run > > 'maven > > > eclipse:eclipse' which generates the Eclipse .classpath, .settings, and > > > .project so you don't need to use m2eclipse at all. That works too. > > > Personally, I like m2eclipse (at least in theory) because it does > > > inter-workspace resolution of projects and updates deps in real time. > It > > > can also download sources / javadoc jars for deps which I absolutely > > > require when debugging. > > > > > > > > > > > > > > Now for a couple of questions... > > > > > > > > *Question 1* > > > > Just wondering what IDE other developers are using for Flume NG? > > > > > > > > > > I know most folks at Cloudera use Eclipse, some with m2eclipse, some > > > without. A few use IntelliJ and a few use just command line tools and > vim > > > or emacs. > > > > > > > > > > > > > > > > > > *Question 2* > > > > I noted that the hdfs sink requires a "timestamp" event header. > > > > > > > > Should the timestamp property be a standard part of an event? i.e. > > > > implemented as part of Event/SimpleEvent? > > > > > > > > > > Probably. Sounds like a bug / improvement. Go ahead and file a JIRA if > > you > > > get a chance. > > > > > > Thanks! > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks > > > > > > > > Regards > > > > Vibul > > > > > > > > > > > > > > > > -- > > > Eric Sammer > > > twitter: esammer > > > data: www.cloudera.com > > > > > > > > > -- > Eric Sammer > twitter: esammer > data: www.cloudera.com >
