[ 
https://issues.apache.org/jira/browse/FLUME-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179167#comment-13179167
 ] 

[email protected] commented on FLUME-918:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3359/
-----------------------------------------------------------

(Updated 2012-01-04 00:32:26.125490)


Review request for Flume.


Changes
-------

in-place AvroSource::toString() to avoid bogus diff in the diff report. 


Summary
-------

AvroSource / AvroSink made abstract, that are agnostic of the Avro object used 
for transport or the interchange between Avro objects and the Flume 'Event's 
and 'Channel's for communication. 


DefaultAvroSource  / DefaultAvroSink in place to preserve existing behavior. 

Custom Avro transports can inherit from AvroSource / AvroSink-s , to override 
the methods. 


This addresses bug FLUME-918.
    https://issues.apache.org/jira/browse/FLUME-918


Diffs (updated)
-----

  
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java
 1226957 
  
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java
 1226957 
  
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java
 1226957 
  
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java
 1226957 

Diff: https://reviews.apache.org/r/3359/diff


Testing
-------


Thanks,

Karthik


                
> customizable avro based processing
> ----------------------------------
>
>                 Key: FLUME-918
>                 URL: https://issues.apache.org/jira/browse/FLUME-918
>             Project: Flume
>          Issue Type: Improvement
>          Components: Sinks+Sources
>    Affects Versions: NG alpha 2
>            Reporter: Kay Kay
>             Fix For: v1.1.0
>
>         Attachments: FLUME-918.patch
>
>
> Currently, flume ships with a flume.avdl that has a reference implementation 
> of a AvroSource / AvroSink , to deal with the default flume transports ( 
> Event / Channel - s) . 
> We need to customize the avro schema that goes in, for our purposes - but 
> would still like to reuse a majority of code of AvroSource  / AvroSink that 
> does the marshalling/ unmarshalling. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to