> On 2012-01-10 19:57:11, Ralph Goers wrote: > > Many of the child poms reference other project artifacts and specify the > > Flume version. It is a better practice to declare a variable in the parent > > pom that declares the Flume version. Then add a dependencyManagement > > section to the parent pom that defines all the Flume artifacts with their > > version. Finally, remove the version in each of the subproject so they will > > pick up the version from the managed dependency.
Thanks for the review Ralph. I agree with your suggestion and will udpate poms accordingly. - Arvind ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3447/#review4302 ----------------------------------------------------------- On 2012-01-10 19:16:02, Arvind Prabhakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3447/ > ----------------------------------------------------------- > > (Updated 2012-01-10 19:16:02) > > > Review request for Flume and Prasad Mujumdar. > > > Summary > ------- > > Also updated the release version from 1.0.0-incubating to > 1.1.0-incubating-SNAPSHOT > > > This addresses bug FLUME-925. > https://issues.apache.org/jira/browse/FLUME-925 > > > Diffs > ----- > > flume-ng-channels/flume-file-channel/pom.xml cbf30ca > flume-ng-channels/flume-jdbc-channel/pom.xml 25061c9 > flume-ng-channels/pom.xml 84e0020 > flume-ng-core/pom.xml a2c4173 > flume-ng-dist/pom.xml 44fe4f9 > flume-ng-node/pom.xml dae20f7 > flume-ng-sinks/flume-hdfs-sink/pom.xml 05444b9 > flume-ng-sinks/pom.xml ea04e7d > pom.xml 7ea3c98 > > Diff: https://reviews.apache.org/r/3447/diff > > > Testing > ------- > > Ran full build with a clean local cache (rm -rf > ~/.m2/repository/org/apache/flume). > > > Thanks, > > Arvind > >
