[
https://issues.apache.org/jira/browse/FLUME-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185946#comment-13185946
]
[email protected] commented on FLUME-932:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3482/#review4373
-----------------------------------------------------------
Ship it!
Looks good overall.
Minor comment -
The factories allow you to call create() multiple times for a same source
name/type and return the source if its already instantiated, on the other hand
the unregister will remove it on first invocation. We should perhaps use
refcounting or raise error on in create if object already exists.
- Prasad
On 2012-01-13 20:40:40, Arvind Prabhakar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3482/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-13 20:40:40)
bq.
bq.
bq. Review request for Flume and Prasad Mujumdar.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Modified all the factories and their default implementations to use
specific Enums (newly added) to locate the plugin classes. See SourceType,
SinkType, ChannelType for details. Modified the Source interface to directly
allow a list of channels. This decommissions the fan-out channel that will be
eventually replaced by the channel selector mechanism (FLUME-930).
bq.
bq.
bq. This addresses bug FLUME-932.
bq. https://issues.apache.org/jira/browse/FLUME-932
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java
6868ae4
bq.
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/JdbcChannel.java
cdaf6d6
bq.
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java
10916c6
bq.
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcTransactionImpl.java
f111392
bq.
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/PersistableEvent.java
eab655a
bq. flume-ng-core/src/main/java/org/apache/flume/Channel.java 6757b75
bq. flume-ng-core/src/main/java/org/apache/flume/ChannelFactory.java 32233b7
bq. flume-ng-core/src/main/java/org/apache/flume/FlumeException.java
PRE-CREATION
bq. flume-ng-core/src/main/java/org/apache/flume/NamedComponent.java
PRE-CREATION
bq. flume-ng-core/src/main/java/org/apache/flume/Sink.java 49ba7c7
bq. flume-ng-core/src/main/java/org/apache/flume/SinkFactory.java 22b1e95
bq. flume-ng-core/src/main/java/org/apache/flume/Source.java 410529f
bq. flume-ng-core/src/main/java/org/apache/flume/SourceFactory.java ce51c17
bq.
flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannel.java
PRE-CREATION
bq. flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java
PRE-CREATION
bq.
flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java
6de7bb3
bq. flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java
7832785
bq. flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java
7305b6c
bq.
flume-ng-core/src/main/java/org/apache/flume/channel/PseudoTxnMemoryChannel.java
0635aab
bq. flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSink.java
f6366d7
bq.
flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java
88739e9
bq. flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java
PRE-CREATION
bq. flume-ng-core/src/main/java/org/apache/flume/source/AbstractSource.java
3e8d5fb
bq. flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java
f20d655
bq.
flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java
01f57cf
bq. flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java
3d5d7d8
bq. flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java
5275f53
bq.
flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java
e4933e9
bq. flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java
PRE-CREATION
bq.
flume-ng-core/src/test/java/org/apache/flume/sink/TestDefaultSinkFactory.java
fd09959
bq. flume-ng-core/src/test/java/org/apache/flume/source/MockSource.java
PRE-CREATION
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java
ec6bbb7
bq.
flume-ng-core/src/test/java/org/apache/flume/source/TestDefaultSourceFactory.java
2bfb9a0
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java
859dd31
bq.
flume-ng-core/src/test/java/org/apache/flume/source/TestPollableSourceRunner.java
f1522d1
bq.
flume-ng-core/src/test/java/org/apache/flume/source/TestSequenceGeneratorSource.java
4383db4
bq.
flume-ng-node/src/main/java/org/apache/flume/conf/file/JsonFileConfigurationProvider.java
e146086
bq.
flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java
12ea809
bq. flume-ng-node/src/main/java/org/apache/flume/node/Application.java
54ab4e0
bq.
flume-ng-node/src/test/java/org/apache/flume/conf/file/TestJsonFileConfigurationProvider.java
498277b
bq.
flume-ng-node/src/test/java/org/apache/flume/node/TestAbstractLogicalNodeManager.java
464a32f
bq.
flume-ng-node/src/test/java/org/apache/flume/node/TestDefaultLogicalNodeManager.java
cc5814f
bq.
flume-ng-node/src/test/java/org/apache/flume/source/TestNetcatSource.java
4af755a
bq. flume-ng-node/src/test/resources/flume-conf.json 0449142
bq.
bq. Diff: https://reviews.apache.org/r/3482/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All tests ran successfully.
bq.
bq.
bq. Thanks,
bq.
bq. Arvind
bq.
bq.
> Making flume-ng components pluggage and name aware
> --------------------------------------------------
>
> Key: FLUME-932
> URL: https://issues.apache.org/jira/browse/FLUME-932
> Project: Flume
> Issue Type: Improvement
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Attachments: FLUME-932-1-svn.patch, FLUME-932-2-svn.patch
>
>
> Currently the components in flume-ng are hard wired to use the built in name.
> This implies that within one agent, there can be only one instance of a
> particular component. While the configuration supports having multiple
> components of the same time, the component interfaces themselves need to
> change.
> Also, need to support plugin components for user-provided implementations of
> source/sink/channels where necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
