> On 2012-01-13 22:52:22, Prasad Mujumdar wrote: > > Looks good overall. > > Minor comment - > > The factories allow you to call create() multiple times for a same source > > name/type and return the source if its already instantiated, on the other > > hand the unregister will remove it on first invocation. We should perhaps > > use refcounting or raise error on in create if object already exists. > >
Thanks Prasad. I have filed https://issues.apache.org/jira/browse/FLUME-933 to track this change. - Arvind ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3482/#review4373 ----------------------------------------------------------- On 2012-01-13 20:40:40, Arvind Prabhakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3482/ > ----------------------------------------------------------- > > (Updated 2012-01-13 20:40:40) > > > Review request for Flume and Prasad Mujumdar. > > > Summary > ------- > > Modified all the factories and their default implementations to use specific > Enums (newly added) to locate the plugin classes. See SourceType, SinkType, > ChannelType for details. Modified the Source interface to directly allow a > list of channels. This decommissions the fan-out channel that will be > eventually replaced by the channel selector mechanism (FLUME-930). > > > This addresses bug FLUME-932. > https://issues.apache.org/jira/browse/FLUME-932 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > 6868ae4 > > flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/JdbcChannel.java > cdaf6d6 > > flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java > 10916c6 > > flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcTransactionImpl.java > f111392 > > flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/PersistableEvent.java > eab655a > flume-ng-core/src/main/java/org/apache/flume/Channel.java 6757b75 > flume-ng-core/src/main/java/org/apache/flume/ChannelFactory.java 32233b7 > flume-ng-core/src/main/java/org/apache/flume/FlumeException.java > PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/NamedComponent.java > PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/Sink.java 49ba7c7 > flume-ng-core/src/main/java/org/apache/flume/SinkFactory.java 22b1e95 > flume-ng-core/src/main/java/org/apache/flume/Source.java 410529f > flume-ng-core/src/main/java/org/apache/flume/SourceFactory.java ce51c17 > flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannel.java > PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java > 6de7bb3 > flume-ng-core/src/main/java/org/apache/flume/channel/FanoutChannel.java > 7832785 > flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java > 7305b6c > > flume-ng-core/src/main/java/org/apache/flume/channel/PseudoTxnMemoryChannel.java > 0635aab > flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSink.java f6366d7 > flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java > 88739e9 > flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java > PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/source/AbstractSource.java > 3e8d5fb > flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java f20d655 > > flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java > 01f57cf > flume-ng-core/src/main/java/org/apache/flume/source/ExecSource.java 3d5d7d8 > flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java > 5275f53 > > flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java > e4933e9 > flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/sink/TestDefaultSinkFactory.java > fd09959 > flume-ng-core/src/test/java/org/apache/flume/source/MockSource.java > PRE-CREATION > flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java > ec6bbb7 > > flume-ng-core/src/test/java/org/apache/flume/source/TestDefaultSourceFactory.java > 2bfb9a0 > flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java > 859dd31 > > flume-ng-core/src/test/java/org/apache/flume/source/TestPollableSourceRunner.java > f1522d1 > > flume-ng-core/src/test/java/org/apache/flume/source/TestSequenceGeneratorSource.java > 4383db4 > > flume-ng-node/src/main/java/org/apache/flume/conf/file/JsonFileConfigurationProvider.java > e146086 > > flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java > 12ea809 > flume-ng-node/src/main/java/org/apache/flume/node/Application.java 54ab4e0 > > flume-ng-node/src/test/java/org/apache/flume/conf/file/TestJsonFileConfigurationProvider.java > 498277b > > flume-ng-node/src/test/java/org/apache/flume/node/TestAbstractLogicalNodeManager.java > 464a32f > > flume-ng-node/src/test/java/org/apache/flume/node/TestDefaultLogicalNodeManager.java > cc5814f > flume-ng-node/src/test/java/org/apache/flume/source/TestNetcatSource.java > 4af755a > flume-ng-node/src/test/resources/flume-conf.json 0449142 > > Diff: https://reviews.apache.org/r/3482/diff > > > Testing > ------- > > All tests ran successfully. > > > Thanks, > > Arvind > >
