----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3503/#review4391 -----------------------------------------------------------
Ship it! +1. In the future, we should probably make this bourne compatible for systems that don't ship bash (hint: I'm looking at you, Solaris). - Eric On 2012-01-14 05:41:16, Bruno Mahé wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3503/ > ----------------------------------------------------------- > > (Updated 2012-01-14 05:41:16) > > > Review request for Flume. > > > Summary > ------- > > Flume ng script is not compatible with Ubuntu's sh implementation > > > This addresses bug FLUME-920. > https://issues.apache.org/jira/browse/FLUME-920 > > > Diffs > ----- > > bin/flume-ng 7c5630c > > Diff: https://reviews.apache.org/r/3503/diff > > > Testing > ------- > > confirmed I could bring up a flume node on ubuntu > > > Thanks, > > Bruno > >
