[ 
https://issues.apache.org/jira/browse/FLUME-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187214#comment-13187214
 ] 

[email protected] commented on FLUME-914:
-----------------------------------------------------



bq.  On 2012-01-16 21:31:54, Prasad Mujumdar wrote:
bq.  > A few space nits, I will take care in the merge.
bq.  > I guess with the latest codebase, you won't need to change the 
Application.java. Please rebase and regenerate the patch, I will go ahead and 
commit it.
bq.  >

The change to Application.java only cleans up unnecessary imports. Do you want 
me to remove that change? it's not part of the ticket, but since it was done...


- Bruno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3502/#review4408
-----------------------------------------------------------


On 2012-01-14 05:38:58, Bruno Mahé wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3502/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-14 05:38:58)
bq.  
bq.  
bq.  Review request for Flume.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Add a IRC sink to flume-ng
bq.  
bq.  
bq.  This addresses bug FLUME-914.
bq.      https://issues.apache.org/jira/browse/FLUME-914
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 5be602a 
bq.    flume-ng-dist/pom.xml 5c20252 
bq.    flume-ng-node/pom.xml c0e295c 
bq.    flume-ng-node/src/main/java/org/apache/flume/node/Application.java 
07151d1 
bq.    flume-ng-sinks/flume-irc-sink/pom.xml PRE-CREATION 
bq.    
flume-ng-sinks/flume-irc-sink/src/main/java/org/apache/flume/sink/irc/IRCSink.java
 PRE-CREATION 
bq.    flume-ng-sinks/pom.xml 044bf8e 
bq.    pom.xml 6002358 
bq.  
bq.  Diff: https://reviews.apache.org/r/3502/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  * All unit tests pass
bq.  * Started a Flume node with an irc sink and confirmed it worked
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Bruno
bq.  
bq.


                
> Port the IRC sink to flume ng
> -----------------------------
>
>                 Key: FLUME-914
>                 URL: https://issues.apache.org/jira/browse/FLUME-914
>             Project: Flume
>          Issue Type: New Feature
>          Components: Sinks+Sources
>            Reporter: Bruno Mahé
>            Assignee: Bruno Mahé
>         Attachments: FLUME-914-01-13.patch, FLUME-914.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to