> On 2012-01-16 07:28:36, Eric Sammer wrote: > > pom.xml, lines 536-540 > > <https://reviews.apache.org/r/3505/diff/1/?file=68955#file68955line536> > > > > I wonder what we should do about plugins going forward. Obviously each > > plugin has its own deps but we don't necessarily want people to have to > > deal with a lot of bloat for features they'll never use. This is fine for > > now, but we should start a FEP or something to figure it out.
I sort of see what you mean but I am not sure to follow. This is in the dependencyManagement section and won't be pulled for any module (unless I got maven wrong). And in this case it is only needed in a test scope for the jms sink and therefore won't be included in the dist tarball or maven module depending on the jms sink (so it's broker independent). This makes me actually wonder if we should include a default broker in the dist tarball so the jms sink can work out of the box? Otherwise users would have to put the needed jar for their favourite broker in flume's classpath - Bruno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3505/#review4392 ----------------------------------------------------------- On 2012-01-14 05:47:18, Bruno Mahé wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3505/ > ----------------------------------------------------------- > > (Updated 2012-01-14 05:47:18) > > > Review request for Flume. > > > Summary > ------- > > Add an implementation for a JMS sink > > > This addresses bug FLUME-923. > https://issues.apache.org/jira/browse/FLUME-923 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 5be602a > flume-ng-dist/pom.xml 5c20252 > flume-ng-node/pom.xml c0e295c > flume-ng-sinks/flume-jms-sink/pom.xml PRE-CREATION > > flume-ng-sinks/flume-jms-sink/src/main/java/org/apache/flume/sink/jms/JMSSink.java > PRE-CREATION > > flume-ng-sinks/flume-jms-sink/src/test/java/org/apache/flume/sink/jms/TestJMSSink.java > PRE-CREATION > flume-ng-sinks/pom.xml 044bf8e > pom.xml 6002358 > > Diff: https://reviews.apache.org/r/3505/diff > > > Testing > ------- > > * Checked unit tests pass, including the one from the JMS sink > * Brought up my own external JMS broker and hooked up a JMS sink on a flume > node > > > Thanks, > > Bruno > >
