[
https://issues.apache.org/jira/browse/FLUME-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199764#comment-13199764
]
[email protected] commented on FLUME-949:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3739/#review4802
-----------------------------------------------------------
Changes look good Jarcec. A couple of feedback points below.
/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/SinkRunner.java
<https://reviews.apache.org/r/3739/#comment10564>
Since now we have only a single Sink type, there does not seem to be any
value in having a SinkRunner interface and a default implementation. Instead, I
suggest removing the SinkRunner interface and making the SinkRunner as a
concrete public class.
/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java
<https://reviews.apache.org/r/3739/#comment10565>
<nit: applies to other sinks as well>: Since AbstractSink already
implements Sink, the specification implementing Sink is redundant. Suggest you
modify this (and other) sink to just extend AbstractSink.
- Arvind
On 2012-02-02 22:10:16, Jarek Cecho wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3739/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-02 22:10:16)
bq.
bq.
bq. Review request for Flume and Arvind Prabhakar.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I've collapsed PollableSink into Sink interface and fixed all other
classes. I'm wondering whether it would make sense to also collapse
PollableSinkRunner into SinkRunner class?
bq.
bq.
bq. This addresses bug FLUME-949.
bq. https://issues.apache.org/jira/browse/FLUME-949
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/PollableSink.java
1239790
bq.
/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/Sink.java
1239790
bq.
/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/SinkRunner.java
1239790
bq.
/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java
1239790
bq.
/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/LoggerSink.java
1239790
bq.
/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/NullSink.java
1239790
bq.
/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/PollableSinkRunner.java
1239790
bq.
/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java
1239790
bq.
/branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java
1239790
bq.
/branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
1239790
bq.
/branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java
1239790
bq.
/branches/flume-728/flume-ng-sinks/flume-irc-sink/src/main/java/org/apache/flume/sink/irc/IRCSink.java
1239790
bq.
bq. Diff: https://reviews.apache.org/r/3739/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. mvn test passes correctly for entire flume-ng project
bq.
bq.
bq. Thanks,
bq.
bq. Jarek
bq.
bq.
> Collapse PollableSink into Sink interface.
> ------------------------------------------
>
> Key: FLUME-949
> URL: https://issues.apache.org/jira/browse/FLUME-949
> Project: Flume
> Issue Type: Task
> Affects Versions: v1.0.0
> Reporter: Arvind Prabhakar
> Assignee: Jarek Jarcec Cecho
> Priority: Critical
> Attachments: FLUME-949.patch
>
>
> See the discussion thread:
> http://markmail.org/thread/e5rfcm2mwg54ofjo
> Summary: We do not have any non-pollable sink types and in order to keep the
> infrastructure and implementation simple, we want to standardize on the
> pollable sink model. Hence it makes sense to remove the explicit notion of
> PollableSink and move the process() method directly into the Sink definition.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
