> On 2012-02-03 18:14:53, Arvind Prabhakar wrote: > > +1. Please attach the patch to the JIRA. > > > > Thanks
I've just uploaded latest version of the patch to JIRA. Sorry that I did not do it earlier, I just needed to get out of the bus :-) - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3739/#review4808 ----------------------------------------------------------- On 2012-02-03 17:21:32, Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3739/ > ----------------------------------------------------------- > > (Updated 2012-02-03 17:21:32) > > > Review request for Flume and Arvind Prabhakar. > > > Summary > ------- > > I've collapsed PollableSink into Sink interface and fixed all other classes. > I'm wondering whether it would make sense to also collapse PollableSinkRunner > into SinkRunner class? > > > This addresses bug FLUME-949. > https://issues.apache.org/jira/browse/FLUME-949 > > > Diffs > ----- > > > /branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/PollableSink.java > 1240228 > /branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/Sink.java > 1240228 > > /branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/SinkRunner.java > 1240228 > > /branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java > 1240228 > > /branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/LoggerSink.java > 1240228 > > /branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/NullSink.java > 1240228 > > /branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/PollableSinkRunner.java > 1240228 > > /branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java > 1240228 > > /branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java > 1240228 > > /branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java > 1240228 > > /branches/flume-728/flume-ng-node/src/test/java/org/apache/flume/node/TestAbstractLogicalNodeManager.java > 1240228 > > /branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java > 1240228 > > /branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java > 1240228 > > /branches/flume-728/flume-ng-sinks/flume-irc-sink/src/main/java/org/apache/flume/sink/irc/IRCSink.java > 1240228 > > Diff: https://reviews.apache.org/r/3739/diff > > > Testing > ------- > > mvn test passes correctly for entire flume-ng project > > > Thanks, > > Jarek > >
