[
https://issues.apache.org/jira/browse/FLUME-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200153#comment-13200153
]
[email protected] commented on FLUME-942:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3701/#review4817
-----------------------------------------------------------
Ship it!
Couple of nits and a potential race on shutdown (which would, in the future, be
used for reconfiguration). Fix those and +1.
flume-ng-legacy-sources/flume-avro-source/src/main/java/org/apache/flume/source/avroOG/AvroOGSource.java
<https://reviews.apache.org/r/3701/#comment10577>
Unless this is for class name level compatibility, the package should be
org.apache.flume...
flume-ng-legacy-sources/flume-thrift-source/pom.xml
<https://reviews.apache.org/r/3701/#comment10578>
Push the version up to the parent pom's dependencyManagement section so we
have centralized control over versions.
flume-ng-legacy-sources/flume-thrift-source/src/main/java/org/apache/flume/source/thrift/ThriftCompatibilitySource.java
<https://reviews.apache.org/r/3701/#comment10579>
Join with threadHandlerThread so we now resources are released. If you
receive an interrupt, propagate.
flume-ng-legacy-sources/flume-thrift-source/src/test/java/org/apache/flume/source/thriftOG/TestThriftOGSource.java
<https://reviews.apache.org/r/3701/#comment10580>
Please don't use wildcard imports.
flume-ng-legacy-sources/pom.xml
<https://reviews.apache.org/r/3701/#comment10576>
Probably shouldn't be called Flume NG Sources anymore, right?
- Eric
On 2012-02-02 17:57:05, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3701/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-02 17:57:05)
bq.
bq.
bq. Review request for Flume and Eric Sammer.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Added thrift and sources to process flume-og thrift event formats.
bq. Flume OG clients can send events directly to these NG sources. Also Flume
OG agents can configure the rcpSinks to send events to these NG sinks.
bq.
bq.
bq. This addresses bug FLUME-942.
bq. https://issues.apache.org/jira/browse/FLUME-942
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-legacy-sources/flume-avro-source/pom.xml PRE-CREATION
bq.
flume-ng-legacy-sources/flume-avro-source/src/main/avro/flumeCompatibility.avdl
PRE-CREATION
bq.
flume-ng-legacy-sources/flume-avro-source/src/main/java/org/apache/flume/source/avroOG/AvroOGSource.java
PRE-CREATION
bq.
flume-ng-legacy-sources/flume-avro-source/src/test/java/org/apache/flume/source/avroOG/TestOGAvroSource.java
PRE-CREATION
bq. flume-ng-legacy-sources/flume-thrift-source/pom.xml PRE-CREATION
bq. flume-ng-legacy-sources/flume-thrift-source/src/main/java/README
PRE-CREATION
bq.
flume-ng-legacy-sources/flume-thrift-source/src/main/java/com/cloudera/flume/handlers/thrift/EventStatus.java
PRE-CREATION
bq.
flume-ng-legacy-sources/flume-thrift-source/src/main/java/com/cloudera/flume/handlers/thrift/Priority.java
PRE-CREATION
bq.
flume-ng-legacy-sources/flume-thrift-source/src/main/java/com/cloudera/flume/handlers/thrift/ThriftFlumeEvent.java
PRE-CREATION
bq.
flume-ng-legacy-sources/flume-thrift-source/src/main/java/com/cloudera/flume/handlers/thrift/ThriftFlumeEventServer.java
PRE-CREATION
bq.
flume-ng-legacy-sources/flume-thrift-source/src/main/java/org/apache/flume/source/thrift/ThriftCompatibilitySource.java
PRE-CREATION
bq.
flume-ng-legacy-sources/flume-thrift-source/src/main/thrift/flumeCompatibility.thrift
PRE-CREATION
bq.
flume-ng-legacy-sources/flume-thrift-source/src/test/java/org/apache/flume/source/thriftOG/TestThriftOGSource.java
PRE-CREATION
bq. flume-ng-legacy-sources/pom.xml PRE-CREATION
bq. pom.xml 2bf32bb
bq.
bq. Diff: https://reviews.apache.org/r/3701/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Regression tests
bq. Added tests for the new sinks
bq. Manually tested event transfer from OG agents to NG thrift and avro
sources.
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Support event compatibility with Flume 0.9x
> -------------------------------------------
>
> Key: FLUME-942
> URL: https://issues.apache.org/jira/browse/FLUME-942
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
>
> Support a thrift and avro source that accepts event from flume 0.9x and
> forwards it to Flume NG event flow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
