[
https://issues.apache.org/jira/browse/FLUME-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206265#comment-13206265
]
[email protected] commented on FLUME-892:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3831/#review5027
-----------------------------------------------------------
See comments below.
flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java
<https://reviews.apache.org/r/3831/#comment11030>
SyslogUtils.extractEvent can return null. It doesn't appear as though
ChannelProcessor.processEvent is prepared to handle null.
flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java
<https://reviews.apache.org/r/3831/#comment11036>
PollableSourceRunner expects the process method to return non-null. Should
BACKOFF be returned or should the IOException be wrapped and rethrown?
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java
<https://reviews.apache.org/r/3831/#comment11031>
Is Source.process supposed to be thread safe? If not, do we have to
allocate this memory each time?
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java
<https://reviews.apache.org/r/3831/#comment11032>
Although 0 is very likely the correct offset, shouldn't we be using
pkt.getOffset()?
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java
<https://reviews.apache.org/r/3831/#comment11034>
As stated earlier, extractEvent could return null?
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java
<https://reviews.apache.org/r/3831/#comment11035>
PollableSourceRunner expects the process method to return non-null. Should
BACKOFF be returned or should the IOException be wrapped and rethrown?
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java
<https://reviews.apache.org/r/3831/#comment11037>
From looking at PollableSourceRunner it looks like the proccess method will
be called if the start method returns non-error. At this point the process
method will NPE correct?
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/3831/#comment11033>
It looks like this method will not throw an IOException?
- Brock
On 2012-02-10 00:43:59, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3831/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-10 00:43:59)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. syslog source support for Flume 1.x
bq.
bq.
bq. This addresses bug FLUME-892.
bq. https://issues.apache.org/jira/browse/FLUME-892
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java
PRE-CREATION
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
PRE-CREATION
bq. flume-ng-core/pom.xml d753fa1
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java
PRE-CREATION
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3831/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. regression tests
bq. Added new test for UDP soruce. tested the TCP source manually. Haven't
found a package that has the tcp syslog client. will add a testcase with custom
tcp client to test the source.
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Support for SysLog as source
> ----------------------------
>
> Key: FLUME-892
> URL: https://issues.apache.org/jira/browse/FLUME-892
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Ravi Bulusu
> Assignee: Prasad Mujumdar
>
> Need SysLog as a source for flume NG.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
