----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3837/#review5036 -----------------------------------------------------------
Ship it! +1. Please attach the patch to the jira. - Arvind On 2012-02-10 18:53:41, Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3837/ > ----------------------------------------------------------- > > (Updated 2012-02-10 18:53:41) > > > Review request for Flume. > > > Summary > ------- > > TestAvroSink fails often for two reasons: > > 1) We call close before the socket has started > 2) We call sink.process before the socket has shutdown > > This puts a small sleep into fix those two issues. > > > This addresses bug FLUME-960. > https://issues.apache.org/jira/browse/FLUME-960 > > > Diffs > ----- > > flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java a46acc0 > > Diff: https://reviews.apache.org/r/3837/diff > > > Testing > ------- > > After the change, I ran the test 120 times and it passed 120 times. > > > Thanks, > > Brock > >
