[
https://issues.apache.org/jira/browse/FLUME-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206583#comment-13206583
]
[email protected] commented on FLUME-960:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3837/#review5036
-----------------------------------------------------------
Ship it!
+1. Please attach the patch to the jira.
- Arvind
On 2012-02-10 18:53:41, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3837/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-10 18:53:41)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. TestAvroSink fails often for two reasons:
bq.
bq. 1) We call close before the socket has started
bq. 2) We call sink.process before the socket has shutdown
bq.
bq. This puts a small sleep into fix those two issues.
bq.
bq.
bq. This addresses bug FLUME-960.
bq. https://issues.apache.org/jira/browse/FLUME-960
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java
a46acc0
bq.
bq. Diff: https://reviews.apache.org/r/3837/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. After the change, I ran the test 120 times and it passed 120 times.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> TestAvroSink.testFailedConnect is racy and fails often
> ------------------------------------------------------
>
> Key: FLUME-960
> URL: https://issues.apache.org/jira/browse/FLUME-960
> Project: Flume
> Issue Type: Bug
> Components: Test
> Affects Versions: v1.0.0
> Reporter: Brock Noland
>
> Sometimes the close in TestAvroSink.testFailedConnect has not closed down
> before we get to the first sink.process as such sink.process fails.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
