[
https://issues.apache.org/jira/browse/FLUME-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206629#comment-13206629
]
[email protected] commented on FLUME-918:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3359/#review5040
-----------------------------------------------------------
Thanks for the patch Karthik. Can you please rebase the patch on the latest
source and add some tests? That will help speed up the review as well. Also,
some minor feedback below from a quick glance.
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java
<https://reviews.apache.org/r/3359/#comment11068>
No tabs please. Use spaces instead.
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSourceProtocolSinkHandler.java
<https://reviews.apache.org/r/3359/#comment11069>
Please use setter instead of field access.
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSourceProtocolSinkHandler.java
<https://reviews.apache.org/r/3359/#comment11070>
Please use getter for headers.
- Arvind
On 2012-01-19 20:44:49, Karthik K wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3359/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-19 20:44:49)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. AvroSource / AvroSink concrete classes has injectible eventHandlers
(SourceEventHandler and SinkEventHandler), to allow for diffrerent avro
protocols to be sent over flume NG. ( not restricted to AvroSourceProtocol ,
as it stands today).
bq.
bq. Default implementation refers to AvroSourceProtocol still though.
bq.
bq.
bq. This addresses bug FLUME-918.
bq. https://issues.apache.org/jira/browse/FLUME-918
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/event/SinkEventHandler.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/event/SourceEventHandler.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSink.java
1233531
bq.
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java
1233531
bq.
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSourceProtocolSinkHandler.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java
1233531
bq.
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/AvroSourceProtocolImpl.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/TransactionManager.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3359/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Karthik
bq.
bq.
> customizable avro source/sink events
> -------------------------------------
>
> Key: FLUME-918
> URL: https://issues.apache.org/jira/browse/FLUME-918
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: NG alpha 2
> Reporter: Karthik K
> Assignee: Karthik K
> Fix For: v1.1.0
>
> Attachments: FLUME-918.patch
>
>
> Currently, flume ships with a flume.avdl that has a reference implementation
> of a AvroSource / AvroSink , to deal with the default flume transports (
> Event / Channel - s) .
> We need to customize the avro schema that goes in, for our purposes - but
> would still like to reuse a majority of code of AvroSource / AvroSink that
> does the marshalling/ unmarshalling.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
