[
https://issues.apache.org/jira/browse/FLUME-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206644#comment-13206644
]
[email protected] commented on FLUME-888:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3741/#review5041
-----------------------------------------------------------
Changes look good. Some feedback follows:
* Please remove trailing whitespaces and tabs where present. These are
highlighted in red on the review board diff.
* The change is missing tests. Since this is an important feature enhancement,
it is necessary to have some basic testing in place to assert that it works and
continues to work.
* The implementation of the decoder depends upon pre-existing headers in the
event. While this will work for planned flows that need to end up in HBase, it
will not work that well for adhoc flows that the user wishes to route to HBase.
In such cases, the requirement to have these headers in place will come in the
way of making use of this. It is therefore preferable to have an alternate
implementation that uses static configuration to place the events in HBase as
well.
flume-ng-sinks/flume-hbase-sink/src/main/java/org/apache/flume/sink/hbase/DefaultEventToPutDecoder.java
<https://reviews.apache.org/r/3741/#comment11071>
The default implementation uses a few hardcoded header names. There should
be a mechanism to override these via configuration if necessary.
- Arvind
On 2012-02-02 23:24:02, Karthik K wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3741/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-02 23:24:02)
bq.
bq.
bq. Review request for Flume and Arvind Prabhakar.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. HBase Sink, ported to Flume NG.
bq.
bq. Configurable EventToPutDecoder in place.
bq.
bq.
bq. This addresses bug FLUME-888.
bq. https://issues.apache.org/jira/browse/FLUME-888
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-sinks/flume-hbase-sink/pom.xml PRE-CREATION
bq.
flume-ng-sinks/flume-hbase-sink/src/main/java/org/apache/flume/sink/hbase/DefaultEventToPutDecoder.java
PRE-CREATION
bq.
flume-ng-sinks/flume-hbase-sink/src/main/java/org/apache/flume/sink/hbase/EventToPutDecoder.java
PRE-CREATION
bq.
flume-ng-sinks/flume-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseEventSink.java
PRE-CREATION
bq. pom.xml 2bf32bb
bq.
bq. Diff: https://reviews.apache.org/r/3741/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested with the DefaultEventToPutDecoder in place, to map Event-s to
Put-s.
bq.
bq.
bq. Thanks,
bq.
bq. Karthik
bq.
bq.
> Port Hbase Sink from OG
> ------------------------
>
> Key: FLUME-888
> URL: https://issues.apache.org/jira/browse/FLUME-888
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Subramanyam Satyanarayana
> Assignee: Subramanyam Satyanarayana
> Fix For: v1.1.0
>
> Attachments: FLUME-888.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> The Flume NG implementation does not have a hbase sink implemented. A good
> starting point would be to port the hbase sink from the Flume OG branch, This
> came out of the flume hackathlon at Cloudera on 12/16/11
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
