----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3869/#review5047 -----------------------------------------------------------
Ship it! - Prasad On 2012-02-11 20:35:37, Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3869/ > ----------------------------------------------------------- > > (Updated 2012-02-11 20:35:37) > > > Review request for Flume. > > > Summary > ------- > > Adds verification to testAppend and testBadSimpleAppend. > Creates common verification method and changes all tests which output data to > this method. > Changes testBadSimpleAppend to all events are processed by sink. > > > This addresses bug FLUME-963. > https://issues.apache.org/jira/browse/FLUME-963 > > > Diffs > ----- > > > flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java > 798028f > > Diff: https://reviews.apache.org/r/3869/diff > > > Testing > ------- > > Ran unit tests in this class in eclipse and all tests through maven. > > > Thanks, > > Brock > >
