-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3994/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
The LoggerSink currently prints the memory address of the Event's body, instead
of the stringified value, which is because it relies on toString() being
implemented in the Event implementation. The reason it prints the memory
address is due to a bug in SimpleEvent's toString() method... however,
SimpleEvent is not guaranteed to have a viable way to stringify its body
contents in general.
I believe it makes sense to remove toString() from SimpleEvent and, with
LoggingSink, assume that the body is always stringifiable and do the decoding
based on the Event interface directly in the class.
This addresses bug FLUME-987.
https://issues.apache.org/jira/browse/FLUME-987
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/event/SimpleEvent.java e0c3b45
flume-ng-core/src/main/java/org/apache/flume/sink/LoggerSink.java f6f9d33
Diff: https://reviews.apache.org/r/3994/diff
Testing
-------
Built and ran using LoggerSink and the body is properly printed.
Thanks,
Mike
